On Tue, 2014-03-11 at 22:42 +0000, Paul Zimmerman wrote: > > From: Dinh Nguyen [mailto:dinh.linux@xxxxxxxxx] > > Sent: Monday, March 10, 2014 5:52 AM > > > > In preparation of combining the dwc2/s3c-hsotg driver in a single DRD driver, > > the defines in dwc2/hw.h needs to get updated so that the s3c-hsotg driver can > > use them. > > > > Signed-off-by: Dinh Nguyen <dinguyen@xxxxxxxxxx> > > Tested-by: Jingoo Han <jg1.han@xxxxxxxxxxx> > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > Cc: Paul Zimmerman <paulz@xxxxxxxxxxxx> > > Cc: Felipe Balbi <balbi@xxxxxx> > > Cc: Ben Dooks <ben-linux@xxxxxxxxx> > > Cc: Matt Porter <mporter@xxxxxxxxxx> > > Cc: Kukjin Kim <kgene.kim@xxxxxxxxxxx> > > Cc: Stephen Warren <swarren@xxxxxxxxxxxxx> > > Cc: Matthijs Kooijman <matthijs@xxxxxxxx> > > Cc: Sachin Kamat <sachin.kamat@xxxxxxxxxx> > > Cc: Robert Baldyga <r.baldyga@xxxxxxxxxxx> > > --- > > v4: none > > v3: > > - Remove unused DXEPCTL_EPTYPE_SHIFT define > > > > v2: > > - No need to redo the GRXSTS_PKTSTS defines > > - Add a FIFOSIZE_DEPTH_GET macro > > Hi Dinh, > > I tested these patches on top of mainline on my Synopsys FPGA board, > and I don't see any functional issues with host mode. Well, I do see > issues with webcams and Ethernet adapters, but they happen even without > your patches, so they are unrelated to your changes. So: > > Tested-by: Paul Zimmerman <paulz@xxxxxxxxxxxx> > Thanks. > However, I wonder why this patch series does not allow to build both > host mode and device mode drivers at the same time? That is a > regression from the current kernel, so I think it is unacceptable. > And I see no reason why both drivers can't be built at once. > The reason why both drivers can't be built the same time is that both drivers are sharing the same compatible string "snps,dwc2". If I enable both drivers, then it appears that only the gadget portion gets loaded and the host driver does not. I'm guessing it would make more sense to be able build both only for dynamically loaded modules? > Once that is fixed, we should try also to get host mode tested by > Stephen Warren (raspberry pi), Matthijs Kooijman (Ralink rt3052), and > Federico Vaga (STMicro STA2X11). Those are the only in-tree users of > dwc2 host mode that I am aware of. > I am having issues with Stephen Warren's email from my altera.com address, so I am sending from my gmail. Dinh -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
