RE: [PATCHv4 1/4] usb: dwc2: Add defines to support the s3c-hsotg driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Dinh Nguyen [mailto:dinh.linux@xxxxxxxxx]
> Sent: Monday, March 10, 2014 5:52 AM
> 
> In preparation of combining the dwc2/s3c-hsotg driver in a single DRD driver,
> the defines in dwc2/hw.h needs to get updated so that the s3c-hsotg driver can
> use them.
> 
> Signed-off-by: Dinh Nguyen <dinguyen@xxxxxxxxxx>
> Tested-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Paul Zimmerman <paulz@xxxxxxxxxxxx>
> Cc: Felipe Balbi <balbi@xxxxxx>
> Cc: Ben Dooks <ben-linux@xxxxxxxxx>
> Cc: Matt Porter <mporter@xxxxxxxxxx>
> Cc: Kukjin Kim <kgene.kim@xxxxxxxxxxx>
> Cc: Stephen Warren <swarren@xxxxxxxxxxxxx>
> Cc: Matthijs Kooijman <matthijs@xxxxxxxx>
> Cc: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
> Cc: Robert Baldyga <r.baldyga@xxxxxxxxxxx>
> ---
> v4: none
> v3:
> - Remove unused DXEPCTL_EPTYPE_SHIFT define
> 
> v2:
> - No need to redo the GRXSTS_PKTSTS defines
> - Add a FIFOSIZE_DEPTH_GET macro

Hi Dinh,

I tested these patches on top of mainline on my Synopsys FPGA board,
and I don't see any functional issues with host mode. Well, I do see
issues with webcams and Ethernet adapters, but they happen even without
your patches, so they are unrelated to your changes. So:

Tested-by: Paul Zimmerman <paulz@xxxxxxxxxxxx>

However, I wonder why this patch series does not allow to build both
host mode and device mode drivers at the same time? That is a
regression from the current kernel, so I think it is unacceptable.
And I see no reason why both drivers can't be built at once.

Once that is fixed, we should try also to get host mode tested by
Stephen Warren (raspberry pi), Matthijs Kooijman (Ralink rt3052), and
Federico Vaga (STMicro STA2X11). Those are the only in-tree users of
dwc2 host mode that I am aware of.

-- 
Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux