Re: [PATCH v3] u_ether: move hardware transmit to RX workqueue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Mar 08, 2014 at 03:39:48PM +0800, clanlab.proj wrote:
> Hi Dave and Greg,
> 
> On Fri, Mar 7, 2014 at 12:04 AM, Felipe Balbi <balbi@xxxxxx> wrote:
> > Hi,
> >
> > On Thu, Mar 06, 2014 at 11:42:49PM +0800, Weinn Jheng wrote:
> >> In order to reduce the interrupt times in the embedded system,
> >> a receiving workqueue is introduced.
> >> This modification also enhanced the overall throughput as the
> >> benefits of reducing interrupt occurrence.
> >>
> >> Signed-off-by: Weinn Jheng <clanlab.proj@xxxxxxxxx>
> >> Cc: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
> >> Cc: David S. Miller <davem@xxxxxxxxxxxxx>
> >
> > Dave, does this look ok from NAPI point of view ?
> 
> I've found the another patch NAPI version has been taken by Greg.

I did?  What git commit id is it?

> But I didn't remembered I've seen the further comment from Dave.
> Since the performance will be a little bit slower then work queue
> according to my experiment before.
> Could someone please give me the comment about the decisions of pros and cons?
> Because I have no idea if there will be further improvement is needed
> for patching NAPI version to work queue.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux