Re: usb/serial/io_ti.c broken on BE systems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johan Hovold <johan@...> writes:
> 
> Care to try the patch below?
> 
> This driver could use some cleaning up so I might rework the patch
> somewhat, but let's find the bugs first.
> 
> Thanks,
> Johan
> 

Hi,

At 1st the driver detected the USB key and set-up the serial ports. But when
trying to write I got a kernel panic on the router.
I finally found that it seems to work properly with 'debug=0', and I also
added the patch below.

So I need:
1- to find what cause the panic on my router with debug=1
2- to test the patch on a LE system.

Thanks for you time,

   Ludovic.

--- io_ti.c.ok2002      2014-02-24 21:54:46.000000000 +0100
+++ io_ti.c     2014-02-24 21:56:33.000000000 +0100
@@ -2408,8 +2408,8 @@
        dbg("bUartMode:   %d", config->bUartMode);
 
        /* move the word values into big endian mode */
-       cpu_to_be16s(&config->wFlags);
-       cpu_to_be16s(&config->wBaudRate);
+       swab16s(&config->wFlags);
+       swab16s(&config->wBaudRate);
 
        status = send_cmd(edge_port->port->serial->dev, UMPC_SET_CONFIG,
                                (__u8)(UMPM_UART1_PORT + port_number),


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux