Francois Romieu [mailto:romieu@xxxxxxxxxxxxx] > Sent: Wednesday, February 19, 2014 3:47 PM > To: hayeswang > Cc: netdev@xxxxxxxxxxxxxxx; nic_swsd@xxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx > Subject: Re: [PATCH net-next 12/14] r8152: replace > netif_rxwithnetif_receive_skb > [...] > The change in rx_bottom is fine. My point is about read_bulk_callback. > > rx_bottom races with read_bulk_callback. rx_bottom is issued in > tasklet (softirq) context. read_bulk_callback is issued in irq > context, with irq disabled. read_bulk_callback does not need to > disable irq itself and could go with spin_lock in place of > spin_lock_irqsave (rx_bottom can't, of course). I think I misunderstand your meaning. I would modify them. Thanks. Best Regards, Hayes -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
