On Monday, February 17, 2014 10:56 AM, Stephen Warren wrote:
>On 02/16/2014 05:37 PM, Jingoo Han wrote:
>> On Friday, February 14, 2014 6:44 PM, Robert Baldyga wrote:
>>> On 02/13/2014 10:10 PM, dinguyen@xxxxxxxxxx wrote:
>>>> From: Dinh Nguyen <dinguyen@xxxxxxxxxx>
>>>>
>>>> Hello,
>>>>
>>>> This patch series combines the dwc2 host driver and the s3c-hsotg peripheral
>>>> driver into a single dual-roler driver similar to the dwc3.
>>>
>>> Hi.
>>> It looks like it doesn't work on Samsung platforms without device-tree
>>> support.
>>
>> Hi Robert Baldyga,
>>
>> In order to test this patch, the current mainline kernel requires
>> additional patches to support device-tree. The following patches
>> are necessary.
>
> DT is supposed to be an ABI (old DTs must work with newer SW), so you
> shouldn't/can't change the code in a way that requires changes to the
> DT, at least for features that are working and stable and already have
> sensible stable DT bindings.
Right, we know it. We should keep DT bindings because these are
Supposed to be an ABI.
I didn't mean to change DT bindings that were already defined at
./Documentation/devicetree/bindings/usb/samsung-hsotg.txt and
./Documentation/devicetree/bindings/usb/samsung-usbphy.txt.
I just suggest that ARCH-DT support code is necessary for Exynos HSOTG
as below.
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -119,6 +119,15 @@
status = "disabled";
};
+ hsotg at 12480000 {
+ compatible = "samsung,s3c6400-hsotg";
+ reg = <0x12480000 0x20000>;
+ interrupts = <0 71 0>;
+ clocks = <&clock 305>;
+ clock-names = "otg";
+ status = "disabled";
+ };
--- a/arch/arm/boot/dts/exynos4210.dtsi
+++ b/arch/arm/boot/dts/exynos4210.dtsi
@@ -114,6 +114,21 @@
interrupts = <2 4>;
};
+ usbphy at 125B0000 {
+ compatible = "samsung,exynos4210-usb2phy";
+ reg = <0x125B0000 0x100>;
+ clocks = <&clock 305>;
+ clock-names = "otg";
+ status = "disabled";
+ ranges;
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ usbphy-sys {
+ reg = <0x10020704 0x8>;
+ };
+ };
Best regards,
Jingoo Han
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
