Hi Alan, On 02/11/2014 05:56 PM, Alan Stern wrote: > On Mon, 10 Feb 2014, Hans de Goede wrote: > >> Disallow ohci- / ehci-platform being built-in, when the phy core is build as >> a module. >> >> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> >> --- >> drivers/usb/host/Kconfig | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig >> index e28cbe0..1dd73e3 100644 >> --- a/drivers/usb/host/Kconfig >> +++ b/drivers/usb/host/Kconfig >> @@ -255,7 +255,7 @@ config USB_EHCI_ATH79 >> >> config USB_EHCI_HCD_PLATFORM >> tristate "Generic EHCI driver for a platform device" >> - depends on !PPC_OF >> + depends on !PPC_OF && (GENERIC_PHY || !GENERIC_PHY) >> default n >> ---help--- >> Adds an EHCI host driver for a generic platform device, which > > Now that PPC_OF isn't an issue, you'll have to redo this patch. Actually I've come up with what I believe is a much better fix, and it does not touch the usb code at all. I had already put Greg in the CC of that fix, but I forgot you, sorry about that, the better fix is here: http://marc.info/?l=linux-arm-kernel&m=139213500427365&w=2 And it seems people like it: http://marc.info/?l=linux-arm-kernel&m=139213733428268&w=2 So hopefully the phy-core maintainer will take it and we can do without adding any deps to drivers/usb/host/Kconfig. If this gets nacked I'll respin my second patch taking your comments into account. Thanks & Regards, Hans > > I'd like to see a comment accompanying the new dependency line, > something like: > > # Don't allow this driver to be built-in if the PHY core is a module > depends on (GENERIC_PHY || !GENERIC_PHY) > > Otherwise, nobody who reads this will understand what's going on. > > Similarly, in the 2/2 patch, put the new dependencies on their own > lines along with a little explanation, such as: > > depends on (GENERIC_PHY || !GENERIC_PHY) # Needed for ehci-platform > > Alan Stern > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
