On Mon, 2014-02-10 at 14:55 +0100, Hans de Goede wrote: > Hi, > > On 02/10/2014 01:26 PM, Oliver Neukum wrote: > > On Mon, 2014-02-10 at 12:58 +0100, Hans de Goede wrote: > >> Hi, > >> > >> On 02/10/2014 07:32 AM, Oliver Neukum wrote: > >>> On Fri, 2014-02-07 at 10:18 -0500, Alan Stern wrote: > >>>> On Fri, 7 Feb 2014, Oliver Neukum wrote: > >>>> > >>>>> Hi, > >>>>> > >>>>> something like this? > >>>> > >>>> Patches in attachments are hard to review in email replies. > >>> > >>> Sorry. > >>> > >>>> Isn't this overkill? All you want to know is whether the bus supports > >>>> bulk streams. A single flag bit in the hcd structure would suffice; > >>>> you don't need to add a whole new method. > >>> > >>> You have a point. > >> > >> So I assume you're going to do a v2 moving to the flag construct? > > > > Yes, I am. I have a tendency to overengineer. But now I know > > what to do. > > Great, thanks! > > >> Having a fix ready for merging when this series gets merged into > >> 3.15 would be good. > > > > Understood. However, I request that you take the patch against UAS. > > It is conceptually a different bug, as it would be a bug (albeit minor) > > even if the storage driver didn't exist. > > uas_probe already calls uas_use_uas_driver() and if that fails already returns > -ENODEV, so as soon as you've fixed uas_use_uas_driver() to do the right > thing on xhci controllers which don't support streams, uas_probe will > correctly return -ENODEV for such controllers. OK, I see. I am making a patch and am going to test it. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
