Hi, On Thursday 06 February 2014 07:37 PM, Tomasz Figa wrote: > Hi Vivek, > > This patch is just adding the PHY driver. I would also like to look at some > users of it, to see how this works when put together. > > For now, please see my comments inline. > > On 20.01.2014 14:42, Vivek Gautam wrote: >> Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. >> The new driver uses the generic PHY framework and will interact >> with DWC3 controller present on Exynos5 series of SoCs. >> Thereby, removing old phy-samsung-usb3 driver and related code >> used untill now which was based on usb/phy framework. >> >> Signed-off-by: Vivek Gautam <gautam.vivek@xxxxxxxxxxx> >> --- >> >> Changes from v2: >> 1) Added support for multiple PHYs (UTMI+ and PIPE3) and >> related changes in the driver structuring. > > I'm a bit skeptical about this separation. Can the PHY operate with just the > UTMI+ or PIPE3 part enabled alone without the other? Can any PHY consumer > operate this way? Theoretically yes. If the USB controller should operate only in high-speed mode, the PIPE3 part is not required at all. However for super speed mode both PIPE3 part and UTMI part should be enabled. Maybe it doesn't work that way with all SoCs because of some HW bug. > > Introducing separation of something that can't exist alone doesn't add any > value, but instead makes things more difficult to work with. Of course, it's IMO separating it into different parts adds more clarity to the driver. Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
