Hi,
On 02/07/2014 11:03 AM, Oliver Neukum wrote:
On Wed, 2014-02-05 at 22:08 +0100, Hans de Goede wrote:
Hi Oliver,
On 02/05/2014 09:13 PM, oliver@xxxxxxxxxx wrote:
From: Oliver Neukum <oneukum@xxxxxxx>
uas_probe() calls usb_alloc_streams(). That can fail on XHCI
with -ENOSYS if the controller doesn't support streams. In that
case devices should be handed over to storage. Thus the driver
needs to return -ENODEV so that the driver core will give other
drivers a chance.
I'm afraid that that won't work, it won't change the result of
uas_use_uas_driver() so usb-storage still will fail to bind.
I'm not sure which version you're looking at, but the new
re-enabled uas code as it will be going upstream for 3.15 is here:
http://git.linuxtv.org/hgoede/gspca.git/shortlog/refs/heads/usb-next-for-sarah
For the above specifically see:
http://git.linuxtv.org/hgoede/gspca.git/commitdiff/dda9e7db4e293defeff4956018183e06749528dc
So to fix this we would need to export if an hcd supports streams
with some hcd flag / property and then as_use_uas_driver() can
check this flag (in combination with connection speed).
Hi,
something like this?
Yes that looks good, can you please send it to linux-usb, with me in the CCm
as a proper inline patch ?
Thanks & Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
