I On Thu, Feb 6, 2014 at 1:09 PM, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote: > On Fri, 31 Jan 2014, Dan Williams wrote: > >> Three reasons: >> 1/ It's an invalid operation on usb3 ports >> 2/ There's no guarantee of when / if a usb2 port has entered an error >> state relative to PORT_POWER request >> 3/ The port is active / powered at this point, so khubd will clear it as >> a matter of course >> >> Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx> >> --- >> drivers/usb/core/port.c | 1 - >> 1 files changed, 0 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/usb/core/port.c b/drivers/usb/core/port.c >> index 2227379be652..32290b8d4f8f 100644 >> --- a/drivers/usb/core/port.c >> +++ b/drivers/usb/core/port.c >> @@ -105,7 +105,6 @@ static int usb_port_runtime_resume(struct device *dev) >> if (retval < 0) > > The comment just above this code says that retval is ignored. Maybe > you could move that part of the comment after the dev_dbg line? I rewrite that comment block in patch 13 "usb: force warm reset to break resume livelock" -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
