On Fri, Feb 07, 2014 at 12:23:19AM +1100, renevant@xxxxxxxxxxxxxxxx wrote: > I experienced the following WARN with a Renesas uPD720201 controller : > > xhci_hcd 0000:02:00.0: WARN Successful completion on short TX: needs > XHCI_TRUST > > Adding the XHCI_NEC_HOST quirk solved the issue. > > > It's possible that this doesn't apply to all Renesas hosts, however it appears > they only officially make 2 hosts, a 2 port (uPD720202) and 4 port (uPD720201) > this patch assumes they both benefit from the NEC quirk. > > --- > > diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c > index 3c898c1..6121411 100644 > --- a/drivers/usb/host/xhci-pci.c > +++ b/drivers/usb/host/xhci-pci.c > @@ -38,6 +38,8 @@ > #define PCI_DEVICE_ID_INTEL_LYNXPOINT_XHCI 0x8c31 > #define PCI_DEVICE_ID_INTEL_LYNXPOINT_LP_XHCI 0x9c31 > > +#define PCI_VENDOR_ID_RENESAS 0x1912 This is already defined in include/linux/pci_ids.h, no need to redefine it here. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html