RE: [PATCH v3] usb: dwc2: handle the Host Port Interrupt when it occurs in device mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx]
> Sent: Wednesday, February 05, 2014 11:36 AM
> 
> On Tue, Feb 04, 2014 at 03:19:40PM -0800, Paul Zimmerman wrote:
> > From: Dinh Nguyen <dinguyen@xxxxxxxxxx>
> >
> > According to the spec for the DWC2 controller, when the PRTINT interrupt fires,
> > the application must clear the appropriate status bit in the Host Port Control
> > and Status register to clear this bit.
> >
> > When disconnecting an A-cable when the dwc2 host driver, the PRTINT fires, but
> > only the GINTSTS_PRTINT status is cleared, no action is done with the HPRT0
> > register. The HPRT0_ENACHG bit in the HPRT0 must also be poked to correctly
> > clear the GINTSTS_PRTINT interrupt.
> >
> > I am seeing this behavoir on v2.93 of the DWC2 IP. When I disconnect an OTG
> > A-cable adapter, the PRTINT interrupt fires when the DWC2 is in device mode
> > and is never cleared.
> >
> > This patch adds the function to read the HPRT0 register when the PRTINT fires
> > and the dwc2 IP has already transitioned to device mode. This function is only
> > clearing the HPRT0_ENACHG bit for now, but can be modified to handle more.
> >
> > Signed-off-by: Dinh Nguyen <dinguyen@xxxxxxxxxx>
> > [ paulz: modified patch to preserve HPRT0_ENA bit ]
> > Signed-off-by: Paul Zimmerman <paulz@xxxxxxxxxxxx>
> > ---
> >  drivers/usb/dwc2/core_intr.c | 25 ++++++++++++++++++++++---
> >  1 file changed, 22 insertions(+), 3 deletions(-)
> 
> Is this a 3.14 or 3.15 patch?

It's not fixing a regression, so 3.15 I would think.

-- 
Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux