Hi Jack, Thanks for the information. Last week, we came to know about this patch from benoitgoby@xxxxxxxxxx. :) We have validated this and it works well. Regards, Roshan -----Original Message----- From: Jack Pham [mailto:jackp@xxxxxxxxxxxxxx] Sent: Wednesday, February 05, 2014 4:19 AM To: Roshan Jhalani Cc: Michal Nazarewicz; mzamponi@xxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx Subject: Re: gadgetfs USB2.0 Chapter 9 Tests: Test after "Addressed State" fails On Tue, Dec 24, 2013 at 05:14:29PM +0100, Michal Nazarewicz wrote: > >>This is a bug in user space. FUNCTIONFS_DISABLE event means the > >>host has chosen a configuration with given function disabled. > >>User-space should clean up it's state, as any pending requests of > >>any >> kind are now invalid. It should not close all of the ep files. > > On Tue, Dec 24 2013, roshan.jhalani@xxxxxxxxxxxx wrote: > > Then, I would say this bug exists in both Android 4.2 and Android > > 4.4 version. But we are facing issue in Android 4.4 because kernel > > uses FunctionFs instead of f_adb.c. > > That may be the case. > > > Do you think this should be ONLY fixed in user space or we can avoid > > all ep releases in kernel? > > I think this should be fixed in user space since kernel space behaves > as it always has and as advertised[1]. Hi Roshan, I believe I ran into the same issue you faced when using the ADB daemon with FunctionFS, and submitted a patch to Android upstream: https://android.googlesource.com/platform/system/core/+/4cbf1d882236462482b8e22893061604b224e308 I figured out that the fix was to hang on to the ep0 file handle, and not always close it, which Michal corroborated in his previous reply. Hope this helps in your case as well. Jack -- Employee of Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
