At Sun, 19 Jan 2014 21:30:58 +0100,
<baumber@xxxxxxxxxxx> wrote:
>
> Hello,
>
> there must be a misunderstanding;
>
> There is a functional change, because with the line/patch ".reset_resume = usb_audio_resume," the mixer of the usb headset was not removed during suspend/resume and so the master channel in KDE Mixer was not changed (Headset), which is the correct behaviour.
>
> Without the line ".reset_resume = usb_audio_resume," in /sound/usb/card.c, the mixer was removed during suspend/resume and re-added, and so the master channel changed in KDE Mixer to the default onboard audio.
>
> I have tested kernel 3.13rc8, and as you mentioned, the "reset_resume"-messages are gone.
> But the behaviour of removing the mixer of the usb_audio_headset occurs, which is, in my opinion, not the correct behaviour, because the chosen master channel/mixer should stay after suspend/resume.
>
> Could you please take a look at the issue again.
Simply adding usb_audio-resume to reset_resume ops doesn't work
properly as Clemens already suggested. It misses the recovery of the
current mixer values. This might work in some cases like S3 (where
the device is kept more or less powered on), but it'll be definitely
broken in some cases like S4.
Takashi
>
> Thanks, Bernhard
>
>
> On 2014-01-13 10:55, Takashi Iwai wrote:
>
> > At Sat, 11 Jan 2014 11:08:39 +0100,
> > The "reset_resume" kernel message was known to be harmless, and now
> > it's degraded as a debug message. That's the only change, so there is
> > no functional change.
> >
> > That being said, you just need to ignore the kernel messages in the
> > old kernels. Or, feel free to submit the commit [0a56b4fa6844: USB:
> > change dev_warn about missing reset-resume to dev_dbg] to stable
> > kernel.
> >
> >
> > Takashi
> >
>
> > <baumber@xxxxxxxxxxx> wrote:
> >>
> >> FWD:
> >>
> >> Any news to the snd-usb-audio issue?
> >>
> >> Thanks, Bernhard
> >>
> >> Old Message:
> >> -------------
> >> I have tested the patch with kernel 3.12.0 with suspend and hibernate, and the problem is gone.
> >>
> >> No messages "no reset_resume for driver snd-usb-audio?" or other negative effects/messages.
> >>
> >> After resume, the usb_audio_device (Headset) is the master channel in KDE Mixer, as it should be.
> >>
> >> => So the problem is solved for me.
> >>
> >> Can you please add the patch to the latest kernels and LTS-kernels or whitelist the workaround for my device (ID 046d:0a29 Logitech, Inc. H600 [Wireless Headset])
> >
>
> >>
> >> Thanks, Bernhard
> >>
> >> On 2013-10-20 23:35, Takashi Iwai wrote:
> >>> At Sun, 20 Oct 2013 23:18:13 +0200,
> >>> <baumber@xxxxxxxxxxx> wrote:
> >>>>
> >>>> On 2013-10-09 11:16 (CEST,UTC+2), Takashi Iwai wrote:
> >>>>>>>> diff --git a/sound/usb/card.c b/sound/usb/card.c
> >>>>>>>> index 9d9de8d..c591a83 100644
> >>>>>>>> --- a/sound/usb/card.c
> >>>>>>>> +++ b/sound/usb/card.c
> >>>>>>>> @@ -747,6 +747,7 @@ static struct usb_driver usb_audio_driver = {
> >>>>>>>> .disconnect = usb_audio_disconnect,
> >>>>>>>> .suspend = usb_audio_suspend,
> >>>>>>>> .resume = usb_audio_resume,
> >>>>>>>> + .reset_resume = usb_audio_resume,
> >>>>>>>> .id_table = usb_audio_ids,
> >>>>>>>> .supports_autosuspend = 1,
> >>>>>>>> };
> >>>>
> >>>> Shall I add the line in b/sound/usb/card.c and try it? Which kernel version shall I use?
> >>>
> >>> It doesn't matter which kernel version is.
> >>> The error message should disappear, but I don't know whether any other
> >>> positive effect you get. As Clemens pointed, there can be some
> >>> negative effects by this, so it cannot be taken as is. But at least,
> >>> it'd be good to know the result...
> >>>
> >>>
> >>> thanks,
> >>>
> >>> Takashi
> >>
> >>
> >>
> >>
> >>
> >>
> >
> >
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
