On Fri, 2014-01-17 at 09:58 +0000, David Laight wrote: > From: Sarah Sharp > > > >- xhci_warn(xhci, "WARN Set TR Deq Ptr cmd failed because " > > > >- "slot %u was not enabled.\n", slot_id); > > > >+ xhci_warn(xhci, "WARN Set TR Deq Ptr cmd failed because slot " > > > >+ "%u was not enabled.\n", slot_id); > > Why leave the line split at the %? Because you can strictly speaking only guess that there's a '%'. > I will grep for things like '".*because slot %'. > Best to only split at an embedded \n. Sorry, the idea just never occured to me. I'd have never dreamt of doing such a grep. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html