On Mon, Jan 13, 2014 at 11:01 AM, Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx> wrote: > On Tue, Jan 07, 2014 at 12:29:28PM -0800, Dan Williams wrote: >> Alan, Sarah, >> >> This revision boils down the port power control fixes to the >> bare minimum to get the implementation functional and reliable. >> Data structure changes are constrained to struct usb_port and >> gone are the clumsier attempts at wider reworks from v1 [1] and >> v2 [2]. No device model changes to consider or changes to the >> meaning of 'runtime_status' for port devices. Three disconnect >> bugs are fixed: >> >> 1/ Superspeed devices downgrade to their hi-speed connection: fix this by >> preventing superspeed poweroff until the peer port is suspended. See >> patch 5. >> >> 2/ khubd taking disconnect action on ports that are in the process of >> being recovered: khubd now ignores ports in the pm-runtime-suspended >> state. Alan, per your comment [3] this effectively uses the pm_usage >> counter and state as a lock against khubd. See patch 7. > > Does that mean this patchset does not depend on the four warm port reset > patches you sent on 12/20? > > http://marc.info/?l=linux-usb&m=138759482824618&w=2 Precisely. That set was aiming to solve some of the interactions by borrowing from the "libsas/libata" approach, but this take is able to achieve the same without that level of surgery. -- Dan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
