Re: [PATCH 1/2] usb: gadget: s3c2410_udc: Fix build error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/13/2014 04:10 AM, Sachin Kamat wrote:
> On 3 January 2014 10:58, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote:
>> Pass value instead of address as expected by 'usb_ep_set_maxpacket_limit'.
>> Fixes the following compilation error introduced by commit e117e742d310
>> ("usb: gadget: add "maxpacket_limit" field to struct usb_ep"):
>>
>> drivers/usb/gadget/s3c2410_udc.c: In function ‘s3c2410_udc_reinit’:
>> drivers/usb/gadget/s3c2410_udc.c:1632:3: error:
>> cannot take address of bit-field ‘maxpacket’
>>    usb_ep_set_maxpacket_limit(&ep->ep, &ep->ep.maxpacket);
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
>> Cc: Robert Baldyga <r.baldyga@xxxxxxxxxxx>

Reviewed-by: Robert Baldyga <r.baldyga@xxxxxxxxxxx>

>> ---
>>  drivers/usb/gadget/s3c2410_udc.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c
>> index f04b2c3154de..dd9678f85c58 100644
>> --- a/drivers/usb/gadget/s3c2410_udc.c
>> +++ b/drivers/usb/gadget/s3c2410_udc.c
>> @@ -1629,7 +1629,7 @@ static void s3c2410_udc_reinit(struct s3c2410_udc *dev)
>>                 ep->ep.desc = NULL;
>>                 ep->halted = 0;
>>                 INIT_LIST_HEAD(&ep->queue);
>> -               usb_ep_set_maxpacket_limit(&ep->ep, &ep->ep.maxpacket);
>> +               usb_ep_set_maxpacket_limit(&ep->ep, ep->ep.maxpacket);
>>         }
>>  }
>>
>> --
>> 1.7.9.5
>>
> 
> Gentle ping, Felipe.
> 

Best regards
Robert Baldyga
Samsung R&D Institute Poland
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux