On 12/31/13 12:27, Sergei Shtylyov wrote:
> Hello.
>
> On 12/31/2013 09:30 PM, Randy Dunlap wrote:
>
>>> Signed-off-by: Rahul Bedarkar <rahulbedarkar89@xxxxxxxxx>
>>> ---
>>> drivers/usb/core/buffer.c | 2 +-
>>> drivers/usb/core/devio.c | 2 +-
>>> drivers/usb/core/hcd.c | 2 +-
>>> drivers/usb/core/hub.c | 6 +++---
>>> drivers/usb/core/hub.h | 2 +-
>>> drivers/usb/core/message.c | 4 ++--
>>> drivers/usb/core/sysfs.c | 2 +-
>>> drivers/usb/core/urb.c | 4 ++--
>>> drivers/usb/core/usb-acpi.c | 2 +-
>>> 9 files changed, 13 insertions(+), 13 deletions(-)
>
>>> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
>>> index bd9dc35..586321c 100644
>>> --- a/drivers/usb/core/hub.c
>>> +++ b/drivers/usb/core/hub.c
>>> @@ -3334,7 +3334,7 @@ static int hub_suspend(struct usb_interface *intf, pm_message_t msg)
>>>
>>> udev = hub->ports[port1 - 1]->child;
>>> if (udev && udev->can_submit) {
>>> - dev_warn(&intf->dev, "port %d nyet suspended\n", port1);
>
>> nyet is a special kind of USB protocol token (packet ID).
>> I suspect that 'nyet' is correct here.
>
> NYET token doesn't have anything to do with port suspend.
Not that this is in the EHCI driver, but include/linux/usb/ehci_def.h
seems to think that a port can be suspended due to a NYET (or I am
misreading it; would not be a surprise):
#define PORTSC_SUSPEND_STS_NYET 1
>
>>> + dev_warn(&intf->dev, "port %d yet suspended\n", port1);
>
> I guess the correct words would be "not yet".
OK.
--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
