On Wed, Feb 15, 2023 at 03:53:23PM +0000, Matthew Wilcox wrote: > On Wed, Feb 15, 2023 at 04:50:04PM +0100, Miklos Szeredi wrote: > > Looks good. One more suggestion: add a vfs_splice() helper and use > > that from do_splice_to() as well. > > I really hate call_read_iter() etc. Please don't perpetuate that > pattern. I think it's time to kill it. I'll prepare a patch for it.