Re: [PATCH v15 05/17] overlayfs: Implement splice-read

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v15 05/17] overlayfs: Implement splice-read
From: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Date: Wed, 15 Feb 2023 15:53:23 +0000
Cc: David Howells <dhowells@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxxxx>, Logan Gunthorpe <logang@xxxxxxxxxxxx>, Hillf Danton <hdanton@xxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Christoph Hellwig <hch@xxxxxx>, John Hubbard <jhubbard@xxxxxxxxxx>, linux-unionfs@xxxxxxxxxxxxxxx
In-reply-to: <CAJfpegt5OurEve+TvzaXRVZSCv0in8_7whMYGsMDdDd2EjiBNQ@mail.gmail.com>

On Wed, Feb 15, 2023 at 04:50:04PM +0100, Miklos Szeredi wrote:
> Looks good.  One more suggestion: add a vfs_splice() helper and use
> that from do_splice_to() as well.

I really hate call_read_iter() etc.  Please don't perpetuate that
pattern.

Follow-Ups:
- Re: [PATCH v15 05/17] overlayfs: Implement splice-read
  - From: Miklos Szeredi
- Re: [PATCH v15 05/17] overlayfs: Implement splice-read
  - From: Christoph Hellwig

References:
- [PATCH v14 05/17] overlayfs: Implement splice-read
  - From: David Howells
- Re: [PATCH v14 05/17] overlayfs: Implement splice-read
  - From: Miklos Szeredi
- [PATCH v15 05/17] overlayfs: Implement splice-read
  - From: David Howells
- Re: [PATCH v15 05/17] overlayfs: Implement splice-read
  - From: Miklos Szeredi

Prev by Date: Re: [PATCH v15 05/17] overlayfs: Implement splice-read
Next by Date: Re: [PATCH v15 05/17] overlayfs: Implement splice-read
Previous by thread: Re: [PATCH v15 05/17] overlayfs: Implement splice-read
Next by thread: Re: [PATCH v15 05/17] overlayfs: Implement splice-read
Index(es):
- Date
- Thread

[Index of Archives] [Linux Filesystems Devel] [Linux NFS] [Linux NILFS] [Linux USB Devel] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]