On Mon, Sep 21, 2020 at 11:55 AM Xiao Yang <yangx.jy@xxxxxxxxxxxxxx> wrote: > > On 2020/9/21 16:17, Amir Goldstein wrote: > > On Mon, Sep 21, 2020 at 10:41 AM Xiao Yang<yangx.jy@xxxxxxxxxxxxxx> wrote: > >> Factor out ovl_ioctl() and ovl_compat_ioctl() and take use of them for > >> directories. > >> > >> Signed-off-by: Xiao Yang<yangx.jy@xxxxxxxxxxxxxx> > >> --- > > This change is buggy. I had already posted it and self NACKed myself [1]. > > > > You can find an hopefully non-buggy version of it on my ovl-shutdown [2] branch. > > > > As long as you are changing ovl_ioctl(), please also take the second > > commit on that > > branch to replace the open coded capability check with the > > vfs_ioc_setflags_prepare() > > generic helper. > Hi Amir, > > Thanks a lot for your quick reply. :-) > I will try to read and understand the metioned patches on your > ovl-shutdown branch. Please also verify my claim in the patch commit message, that the the test result of xfstest generic/079 changes from "notrun" to "success". Thanks, Amir.
