On Mon, Sep 21, 2020 at 10:41 AM Xiao Yang <yangx.jy@xxxxxxxxxxxxxx> wrote: > > Factor out ovl_ioctl() and ovl_compat_ioctl() and take use of them for > directories. > > Signed-off-by: Xiao Yang <yangx.jy@xxxxxxxxxxxxxx> > --- This change is buggy. I had already posted it and self NACKed myself [1]. You can find an hopefully non-buggy version of it on my ovl-shutdown [2] branch. As long as you are changing ovl_ioctl(), please also take the second commit on that branch to replace the open coded capability check with the vfs_ioc_setflags_prepare() generic helper. Thanks, Amir. [1] https://lore.kernel.org/linux-unionfs/CAOQ4uxhRgL2sMok7xsAZN6cZXSfoPxx=O8ADE=72+Ta3hGoLbw@xxxxxxxxxxxxxx/ [2] https://github.com/amir73il/linux/commits/ovl-shutdown
