On Tue, 2019-10-29 at 12:01 -0500, Serge E. Hallyn wrote: > On Fri, Oct 25, 2019 at 01:35:20PM +0200, Miklos Szeredi wrote: > > On Fri, Oct 25, 2019 at 1:30 PM Miklos Szeredi <mszeredi@xxxxxxxxxx > > > wrote: > > > Hi Eric, > > > > > > Can you please have a look at this patchset? > > > > > > The most interesting one is the last oneliner adding > > > FS_USERNS_MOUNT; > > > whether I'm correct in stating that this isn't going to introduce > > > any > > > holes, or not... > > > > Forgot the git tree: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git#ovl- > > unpriv > > > > Thanks, > > Miklos > > I've looked through it, seemed sensible to me. Seems sensible to me too but I'm not sure what I'm looking for. Perhaps a bit more on how this is secure to give an idea what's been checked and where to focus so the the survey can be broadened from there... I'm not sure. For example, from my simple minded view I wonder about the posix acl code. In ovl_posix_acl_xattr_set() there is a call to posix_acl_from_xattr() that uses init_user_ns. I wonder if that should be the current user ns in this case but I'm not sure? Ian
