On Wed, Feb 19, 2020 at 4:28 PM Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > On Wed, Feb 19, 2020 at 4:25 PM Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > > While this makes sense on 64bit arch, it's going to overflow on 32bit > > (due to i_ino being "unsigned long"). > > It's not clear here, but on 32bit, xinobits is 0: > > ofs->xino_mode = BITS_PER_LONG - 32; > > To the expression doesn't change i_ino. > Correct? > Want me to clarify that by comment or by code? Ah, missed that. I think no need to clarify further. > Yeh, it's mostly the same. Branch ovl-ino is already rebased. > If you have no other comments, I'll prepare v2 and test it with 5.6-rc2. Thanks. I've already applied the patches leading up to this and just pushed to #overlayfs-next. Thanks, Miklos
