Re: [PATCH] ovl: fix wrong WARN_ON() in ovl_cache_update_ino()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 21, 2020 at 11:04 AM Amir Goldstein <amir73il@xxxxxxxxx> wrote:
>
> On Mon, Jan 6, 2020 at 8:35 AM Amir Goldstein <amir73il@xxxxxxxxx> wrote:
> >
> > On Mon, Dec 23, 2019 at 8:40 AM Amir Goldstein <amir73il@xxxxxxxxx> wrote:
> > >
> > > The WARN_ON() that child entry is always on overlay st_dev became wrong
> > > when we allowed this function to update d_ino in non-samefs setup with
> > > xino enabled.
> > >
> > > It is not true in case of xino bits overflow on a non-dir inode.
> > > Leave the WARN_ON() only for directories, where assertion is still true.
> > >
> > > Fixes: adbf4f7ea834 ("ovl: consistent d_ino for non-samefs with xino")
> > > Cc: <stable@xxxxxxxxxxxxxxx> # v4.17+
> > > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx>
> > > ---
> > >
> >
> > Miklos,
> >
> > If you have time, please send this one to Linus for v5.5.
> > It is a simple fix and the only one causing failure in the new xfstests [1]
> > that I posted.
> >
>
> Gentle nudge..

I'm working this into the next batch bound for 5.6, unless something
more urgent comes up before that.

Thanks,
Miklos



[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux