On Thu, Oct 31, 2019 at 2:20 PM Vivek Goyal <vgoyal@xxxxxxxxxx> wrote:
>
> On Thu, Oct 31, 2019 at 08:53:15AM +0200, Amir Goldstein wrote:
> >
> > @@ -483,7 +483,7 @@ static int ovl_copy_up_inode(struct
> > ovl_copy_up_ctx *c, struct dentry *temp)
> > }
> >
> > inode_lock(temp->d_inode);
> > - if (c->metacopy)
> > + if (S_ISREG(c->stat.mode))
> > err = ovl_set_size(temp, &c->stat);
>
> Hi Amir,
>
> Why do we need this change. c->metacopy is set only for regular files.
>
> ovl_need_meta_copy_up() {
> if (!S_ISREG(mode))
> return false;
> }
>
> Even if there is a reason, this change should be part of a separate patch.
> What connection does it have to skip holes while copying up.
That's a fix only if the copied-up file ends in a hole, which was not
the case before this patch. But harmless, and makes sense generally
(i.e. file is truncated to final size *before* data is copied up).
Thanks,
Miklos
