On Wed, Nov 7, 2018 at 12:59 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: > OK. (including RENAME_WHITEOUT and d_type) > > But what about being "strict" about the need for underlying fs > to support file handles for index and nfs_export? Yes, that one as well. > The "thorny part" is that with your implementation of > metacopy/redirect_dir all the decisions can be made at the end of options > parsing. With nfs_export, mount option can turn it on and then no file handle > support will turn it off. > If at option parsing time we let nfs_export imply !redirect_dir, we are > left with !redirect_dir and !nfs_export. We could do the option interdependency resolution after detecting features. > and Kconfig will choose metacopy if both are set to Y... > > I think current direction makes sense. In the system/distro level it makes > sense for the default to be efficient in copy up. In the fs instance level, > user/application can opt-in for NFS export feature in favor of efficient > copy up. Makes sense. Thanks, Miklos
