On Thu, Nov 1, 2018 at 2:11 PM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > On Thu, Nov 1, 2018 at 2:03 PM, Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: >> On Thu, Nov 01, 2018 at 02:48:09AM +0200, Amir Goldstein wrote: > >>> >>> case OPT_METACOPY_ON: >>> config->metacopy = true; >>> + config->strict = true; >> >> I think either ->strict should go in a separate patch or we should have >> a good description in commit message, explaining why ->strict is there >> and how it will impact behavior going forward. > > I'm redoing Amir's patches a bit, and at the moment I'm more inclined > to leave this after the merge window, since there are so many subtle > details to deal with. > > Back shortly with an updated set. ...this is more complicated than I thought. Anyway, pushed a metacopy fix to overlayfs-next, that I'm pretty happy with. I don't think erroring out on noxattr is important; falling back is actually quite sane. And it isn't going to be an issue in real life, since xattr is supported on lots of fs, and it's unlikely that lots of people will want to use overlayfs with e.g. minix as the upper layer. Thanks, Miklos
