On Wed, Aug 01, 2018 at 02:35:27PM +0300, Amir Goldstein wrote: > On Wed, Aug 1, 2018 at 2:30 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > On Tue, Jul 31, 2018 at 12:37 PM, zhangyi (F) <yi.zhang@xxxxxxxxxx> wrote: > >> After we introduce the fsck.overlay program, we could check and fix > >> the inconsistency of feature set xattr, so it's a good opportunity > >> check the redirect dir feature when we detect redirect xattr on > >> directory in the underlying layer. If the feature is necessary > >> (OVL_FS_V2 for all layers and OVL_FS_UPPER_V2 for upper layer) but > >> the redirect dir feature is missing, the feature set is inconsistent > >> and fsck.overlay is required. > >> > >> Signed-off-by: zhangyi (F) <yi.zhang@xxxxxxxxxx> > >> --- > > The concept of this patch is fine, but I would really like to review > it only after rebase with metacopy, because there are pretty big changes > for lookup+redirecet in metacopy patches. > And I would love to get Vivek's feedback on this patch. I am just trying to understand what's going on on this patch series. Zhangyi, There are lots of details in first email but high level picture is missing. It would help if there was a README or 2-3 paragraphs explaining what's the problem and how you are solving it. I feel description directly jumps to details of "how some problem is being solved". While it works for the people who know about it, I am scratching my head. Will be nice, if in next posting if you could also describe, what's the problem you are solving. > > Also, it might be enough just to check the feature bit inside > ovl_check_redirect() and warn - I am not sure that failing the lookup > is called for. Without knowing much, I agreed that failing lookup feels little drastic. A warning that running fsck.overlay is recommended, sounds more appropriate. Also agreed that its easier to review this after metadata only copy up patches are merged. ovl_lookup() and friends have changed significantly and once this patch is rebased on top of that, its easier to review. Thanks Vivek -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
