On Wed, Aug 1, 2018 at 2:30 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: > On Tue, Jul 31, 2018 at 12:37 PM, zhangyi (F) <yi.zhang@xxxxxxxxxx> wrote: >> After we introduce the fsck.overlay program, we could check and fix >> the inconsistency of feature set xattr, so it's a good opportunity >> check the redirect dir feature when we detect redirect xattr on >> directory in the underlying layer. If the feature is necessary >> (OVL_FS_V2 for all layers and OVL_FS_UPPER_V2 for upper layer) but >> the redirect dir feature is missing, the feature set is inconsistent >> and fsck.overlay is required. >> >> Signed-off-by: zhangyi (F) <yi.zhang@xxxxxxxxxx> >> --- The concept of this patch is fine, but I would really like to review it only after rebase with metacopy, because there are pretty big changes for lookup+redirecet in metacopy patches. And I would love to get Vivek's feedback on this patch. Also, it might be enough just to check the feature bit inside ovl_check_redirect() and warn - I am not sure that failing the lookup is called for. Thanks, Amir. -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
