Re: [PATCH v15 00/30] overlayfs: Delayed copy up of data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 08, 2018 at 05:16:54PM +0300, Amir Goldstein wrote:
> On Tue, May 8, 2018 at 4:42 PM, Vivek Goyal <vgoyal@xxxxxxxxxx> wrote:
> > On Mon, May 07, 2018 at 01:40:32PM -0400, Vivek Goyal wrote:
> >> Hi,
> >>
> >> This is V15 of overlayfs metadata only copy-up feature. These patches I
> >> have rebased on top of Miklos overlayfs-next tree's branch overlayfs-rorw.
> >>
> >> git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs-rorw
> >>
> >> Patches are also available here.
> >>
> >> https://github.com/rhvgoyal/linux/commits/metacopy-v15
> >>
> >> I have run unionmount-testsuite and "./check -overlay -g quick" and that
> >> works. Only 4 overlay tests fail, which fail on vanilla kernel too.
> >>
> >
> > Hi Amir,
> >
> > I have taken care of your review comments and pushed new patches at
> > "metcopy-next" branch.
> >
> > https://github.com/rhvgoyal/linux/commits/metacopy-next
> 
> Looks good.

Given all the work w.r.t fixing races and making use of ovl_get_inode()
in ovl_instantiate(), I have rebased my patches on top of Amir's ovl-fixes
branch and pushed it to "metacopy-next-ovl-fixes" branch.

https://github.com/rhvgoyal/linux/commits/metacopy-next-ovl-fixes

With usage of ovl_get_inode() in ovl_instantiate(), I realized that I
should not have to call ovl_set_upperdata() now explicitly as
ovl_get_inode() will take care of that anyway. So I dropped it. Also
dropped similar call from export.c as it felt redundant.

I might do another posting of patches once all the ovl_get_inode()
related cleanup gets merged and shows up in Miklos's tree.

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux