Re: [PATCH v4 0/3] option validation in remount

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



在 2018年4月13日,下午8:56,Amir Goldstein <amir73il@xxxxxxxxx> 写道:
> 
> On Fri, Apr 13, 2018 at 3:39 PM, Chengguang Xu <cgxu519@xxxxxxx> wrote:
>> Some overlayfs mount options cannot be changed via remount,
>> but current remount does not return error even if we specify
>> different value to unchangeable options.
>> 
>> This patch series adjust option parsing to support remount
>> and return proper error message and code when recogonizing
>> unchangeable options in remount.
>> 
> 
> Surely, you have motivation beyond what is listed here.
> Would be nice to list short and long term goals for changing
> remount options.
> 
> The series looks ok to me.
> There is a question whether erroring on remount with changed
> options is considered a regression to some applications.
> I don't know how to answer that.
> Does your use case *require* that remount will fail?
> Would it be ok to ignore unchangeable options like today,
> but warn about it?

hmmm, some of our sysadmins get confused by the phenomenon of
success remount without changing options. It’s obviously different
compare to other filesystems but I think with proper explanation
they can accept this and change their scripts.


> 
> After Miklos approves the expected behavior,
> please write xfstests to verify expected behavior.

Sure, I’ll make a case to verify it.

--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux