> 在 2018年4月13日，下午9:46，Miklos Szeredi <miklos@xxxxxxxxxx> 写道： > > On Fri, Apr 13, 2018 at 2:56 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: >> On Fri, Apr 13, 2018 at 3:39 PM, Chengguang Xu <cgxu519@xxxxxxx> wrote: >>> Some overlayfs mount options cannot be changed via remount, >>> but current remount does not return error even if we specify >>> different value to unchangeable options. >>> >>> This patch series adjust option parsing to support remount >>> and return proper error message and code when recogonizing >>> unchangeable options in remount. >>> >> >> Surely, you have motivation beyond what is listed here. >> Would be nice to list short and long term goals for changing >> remount options. >> >> The series looks ok to me. >> There is a question whether erroring on remount with changed >> options is considered a regression to some applications. > > Theoretically: yes. In real life: maybe. We need to be careful. > >> I don't know how to answer that. >> Does your use case *require* that remount will fail? >> Would it be ok to ignore unchangeable options like today, >> but warn about it? > > Adding a warning is definitely okay, since it makes no sense to supply > unchangeable options. Maybe at some point we can change the warning > to a failure. > > It would have been best to error out on unknown/unchangeable options > from the start. Hopefully the new mount API will make implementing > option parsing and reconfiguration less error prone. I’ll modify the code to only print warning but not return error code when user trying to change unchangeable options, but if user specifies unrecognized option or the option is invalid then still return -EINVAL. Thanks, Chengguang. -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
