On Thu, Dec 14, 2017 at 5:02 PM, Eryu Guan <eguan@xxxxxxxxxx> wrote: > On Thu, Dec 14, 2017 at 04:46:21PM +0200, Amir Goldstein wrote: >> On Thu, Dec 14, 2017 at 4:19 PM, Chengguang Xu <cgxu519@xxxxxxxxxx> wrote: >> > check -overlay overrides SCRATCH_MNT variable to it's own, >> > so adjust target to underlying filesystem(OVL_BASE_SCRATCH_MNT) >> > when running shutdown on overlayfs. >> > >> > Introduce a helper _scratch_shutdown to mainly handle scratch >> > shutdown and convert godown to _scratch_shutdown to support >> > overlayfs running on below cases. >> >> You should do this in 2 patches: >> 1. replace all open coded godown calls with _scratch_shutdown helper >> 2. Add overlay support to _scratch_shutdown helper. > > The description is not clear enough, the updates are not for running > existing shutdown tests to run on overlay, but to avoid test failures > using the bare 'src/godown $SCRATCH_MNT' when _require_scratch_shutdown > accepts overlay to run. e.g. > > +/root/xfstests/src/godown: error on xfsctl(GOINGDOWN) of "/mnt/scratch/ovl-mnt": Inappropriate ioctl for device > > So I think it's proper to do all the required updates in one patch, > instead of introducing (intermediate) false failures, and fixing them in > a follow-up patch. > I take your word for it. In that case, I'll wait for the patch will clearer description. Amir. -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
