Re: [PATCH v4 1/3] common/rc: add scratch shutdown support for overlayfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 14, 2017 at 4:19 PM, Chengguang Xu <cgxu519@xxxxxxxxxx> wrote:
> check -overlay overrides SCRATCH_MNT variable to it's own,
> so adjust target to underlying filesystem(OVL_BASE_SCRATCH_MNT)
> when running shutdown on overlayfs.
>
> Introduce a helper _scratch_shutdown to mainly handle scratch
> shutdown and convert godown to _scratch_shutdown to support
> overlayfs running on below cases.

You should do this in 2 patches:
1. replace all open coded godown calls with _scratch_shutdown helper
2. Add overlay support to _scratch_shutdown helper.

>
> generic/043
> generic/044
> generic/045
> generic/046
> generic/047
> generic/048
> generic/051
> generic/052
> generic/054
> generic/055
> generic/392
> generic/417
> generic/461
> generic/468

Really no need to specify these in change log. They already appear in diffstat.

>
> In order to avoid overlayfs running on improper shutdown
> cases, add _require_local_device $SCRATCH_DEV to below cases.

I don't understand.
In all these tests, there is already _require_scratch_shutdown.
Shouldn't that prevent overlay running improper shutdown?

Amir.
--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux