On Mon, Dec 11, 2017 at 9:59 PM, Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: > On Fri, Dec 08, 2017 at 06:29:53PM +0200, Amir Goldstein wrote: >> On Wed, Dec 6, 2017 at 9:14 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: >> > On Wed, Dec 6, 2017 at 8:17 PM, Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: >> >> On Tue, Dec 05, 2017 at 10:20:25PM +0200, Amir Goldstein wrote: >> >>> Hi All, >> >>> >> >>> The master branch on my unionmount-testsuite tree [1] has been updated. >> >>> >> >>> The head of the master branch is commit: >> >>> 6d04664 Add a test for rename over empty union dir >> >>> >> >>> This small update contains: >> >>> - A few new simple dir rename and dir remove tests >> >>> - A fix for running on kernel <= v4.9 with no redirect_dir support >> >>> - A new setup option --squashfs to setup lower as read-only squashfs >> >>> >> >> >> >> Hi Amir, >> >> >> >> It would be nice to also update README file and explain different options. >> > >> > Yes, that would be nice... will get to it some day if someone doesn't >> > beat me to it. >> > >> >> >> >> Also, how to test with different mount options enabled/disable (index, >> >> redirect etc). >> >> >> > >> > A preview for README: >> > Basically, the testsuite tests for correctness, so if correctness requires >> > enabling a feature, then testsuite will fail without the feature, but there are >> > some historical exceptions: >> > - testsuite predates redirect_dir, so I let the testsuite auto detect >> > redirect_dir >> > and kept the "expect EXDEV" logic for redirect_dir disabled >> > - until quite recently st_ino was not constant on copy up in most cases, >> > so the verification of constant ino was added as an opt-in feature >> > with --verify >> > >> > >> >>> With index enabled, there are no known failures. >> >>> With index disabled this test fails on non-constant st_ino for lower hardlink >> >>> copy up: >> >>> run --ov=1 --samefs --verify rename-mass-5 >> > >> > Thus, this test fails because with index disabled, hardlink is broken on copy up >> > and does not preserve st_ino. >> > >> >> Vivek, >> >> I added documentation about all the features I added to unionmount-testsuite at: >> https://github.com/amir73il/overlayfs/wiki/Overlayfs-testing#Unionmount_testsuite >> >> Will add that link to README on the next master branch update. >> Let me know if there is anything missing for you in this wiki page. > > Hi Amir, > > Thanks a lot for this documentation. I tested it and it works for me. So > far I was only running "./run --ov". Now I can do samefs setups and also > verify index feature etc. > > Two minor nits/queries. > > - Right now "./run --ov --samefs -s" fails if "/base" directory is not > there. So in mkdir command, add "base" to the list also. Fix. Thanks for review! > > - For the xfs reflink test, I am curious that why have you recommended > to also enabled "rmapbt=1". Is is required for the tests? > You cannot enable reflink=1 without it. Amir. -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
