Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > + const char *redirect_mode; > ... > + kfree(ofs->config.redirect_mode); That's going to get you a compiler warning under some circumstances. > + config->redirect_mode = match_strdup(&args[0]); We shouldn't really be copying the string if we can help it, though I grant we may not have the match_*() function to do otherwise at the moment. I would much prefer seeing it rendered to an enum value at this point. David -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
