On Mon, Jul 10, 2017 at 07:15:47PM +0300, Amir Goldstein wrote: > > 1064 > > 1065 if (ufs->indexdir) { > > ^^^^^^^^^^^^^ > > We check for NULL here so the code so that's OK except what do we want to > > set the error code to if ovl_workdir_create() fails? Right now it's > > set to a random pointer casted to int. > > I don't follow. > If ovl_workdir_create() fails, ufs->indexdir will be NULL and err will be 0. > If it succeeds err will be set here below. > Oh, yeah. You're right. My bad. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html