On Mon, Jul 10, 2017 at 5:16 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> Hello Amir Goldstein,
>
> The patch 02bcd1577400: "ovl: introduce the inodes index dir feature"
> from Jun 21, 2017, leads to the following static checker warning:
>
> fs/overlayfs/super.c:1062 ovl_fill_super()
> warn: 'ufs->indexdir' isn't an ERR_PTR
>
> fs/overlayfs/super.c
> 1050 if (!(ovl_force_readonly(ufs)) && ufs->config.index) {
> 1051 /* Verify lower root is upper root origin */
> 1052 err = ovl_verify_origin(upperpath.dentry, ufs->lower_mnt[0],
> 1053 stack[0].dentry, false, true);
> 1054 if (err) {
> 1055 pr_err("overlayfs: failed to verify upper root origin\n");
> 1056 goto out_put_lower_mnt;
> 1057 }
> 1058
> 1059 ufs->indexdir = ovl_workdir_create(sb, ufs, workpath.dentry,
> 1060 OVL_INDEXDIR_NAME, true);
> 1061 err = PTR_ERR(ufs->indexdir);
> 1062 if (IS_ERR(ufs->indexdir))
> 1063 goto out_put_lower_mnt;
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> This hunk isn't needed any more now that ovl_workdir_create() doesn't
> return error pointers.
Yes, its not needed.
I will send a cleanup patch later.
>
> 1064
> 1065 if (ufs->indexdir) {
> ^^^^^^^^^^^^^
> We check for NULL here so the code so that's OK except what do we want to
> set the error code to if ovl_workdir_create() fails? Right now it's
> set to a random pointer casted to int.
I don't follow.
If ovl_workdir_create() fails, ufs->indexdir will be NULL and err will be 0.
If it succeeds err will be set here below.
>
> 1066 /* Verify upper root is index dir origin */
> 1067 err = ovl_verify_origin(ufs->indexdir, ufs->upper_mnt,
> 1068 upperpath.dentry, true, true);
> 1069 if (err)
> 1070 pr_err("overlayfs: failed to verify index dir origin\n");
> 1071
> 1072 /* Cleanup bad/stale/orphan index entries */
> 1073 if (!err)
> 1074 err = ovl_indexdir_cleanup(ufs->indexdir,
> 1075 ufs->upper_mnt,
> 1076 stack, numlower);
> 1077 }
> 1078 if (err || !ufs->indexdir)
> 1079 pr_warn("overlayfs: try deleting index dir or mounting with '-o index=off' to disable inodes index.\n");
> 1080 if (err)
> 1081 goto out_put_indexdir;
>
> regards,
> dan carpenter
Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
