Re: [RFC PATCH V2] ovl:fix rmdir problem on impure dir

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



on 2017/6/20 15:04, Amir Goldstein wrote:
> On Tue, Jun 20, 2017 at 9:10 AM, zhangyi (F) <yi.zhang@xxxxxxxxxx> wrote:
>> On 2017/6/19 20:07, Amir Goldstein Wrote:
>>> On Mon, Jun 19, 2017 at 2:44 PM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote:
>>>> On Mon, Jun 19, 2017 at 1:19 PM, zhangyi (F) <yi.zhang@xxxxxxxxxx> wrote:
>>>>> On 2017/6/19 16:28, Amir Goldstein wrote:
>>>>>> On Mon, Jun 19, 2017 at 10:59 AM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote:
>>>>>>> On Mon, Jun 19, 2017 at 6:00 AM, zhangyi (F) <yi.zhang@xxxxxxxxxx> wrote:
> 
> My plans were to defer it to next-next (v4.14) merge cycle along with
> NFS export.
> 
> I suggest that you post a fix to the whiteout problem based on (MERGE
> || ORIGIN),
> disregarding the issue of pre kernel v4.12 upper layers (MERGE && !ORIGIN).
> 

Okay, I will try to use current (MERGE || ORIGIN) to fix, the (MERGE && !ORIGIN)
issue will be fixed automatically after you merge your patchset. Thanks for your
suggestion.

> After my current patch set lands on linux-next, or even after v4.13-rc1, we
> can decide if it is worth while to merge the extra hunk above for the sake of
> fixing whiteout problem with pre v4.12 upper layers.
> 
> Does your use case have to deal with migrating existing upper layers?
> 

I don't have this use case this moment(maybe have in future), it's not urgent.

> BTW, does you use case also care about other types of lower layer changes?
> As part of the work for overlayfs snapshots and NFS export, I also plan to
> post patches to follow renamed lower dir to their new location, instead of
> treating the upper dir as !MERGE, see:
> https://github.com/amir73il/linux/commits/ovl-verify-dir

This case is interesting, I don't have this case too (not so sure), I will
think about this, thanks for reminding.

Thanks,
ZhangYi.




--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux