Re: [PATCH v6 05/21] tracing: probeevent: Cleanup print argument functions
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v6 05/21] tracing: probeevent: Cleanup print argument functions
- From: Steven Rostedt <rostedt@xxxxxxxxxxx>
- Date: Fri, 23 Mar 2018 12:36:47 -0400
- Cc: linux-kernel@xxxxxxxxxxxxxxx, Ingo Molnar <mingo@xxxxxxxxxx>, Namhyung Kim <namhyung@xxxxxxxxxx>, Tom Zanussi <tom.zanussi@xxxxxxxxxxxxxxx>, Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>, linux-trace-users@xxxxxxxxxxxxxxx, linux-kselftest@xxxxxxxxxxxxxxx, shuah@xxxxxxxxxx, Ravi Bangoria <ravi.bangoria@xxxxxxxxxxxxxxxxxx>
- In-reply-to: <152129047203.31874.3188700720826213215.stgit@devbox>
- References: <152129024033.31874.15800253385376959274.stgit@devbox> <152129047203.31874.3188700720826213215.stgit@devbox>
On Sat, 17 Mar 2018 21:41:12 +0900
Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
> Current print argument functions prints the argument
> name too. It is not good for printing out multiple
> values for one argument. This change it to just print
> out the value.
Hi Masami,
This is a confusing change log, as I have no idea what this patch does.
Can you add a "before" and "after" of what you mean. Some examples of
what it currently does to show why it looks bad, and then an example of
what it looks like after the patch.
Thanks!
-- Steve
>
> Signed-off-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-trace-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]