Re: [PATCH] PERF(kernel): Cleanup power events V2
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] PERF(kernel): Cleanup power events V2
- From: Pierre Tardy <tardyp@xxxxxxxxx>
- Date: Tue, 26 Oct 2010 13:15:31 -0500
- Cc: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Thomas Renninger <trenn@xxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx>, Frank Eigler <fche@xxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx>, linux-omap@xxxxxxxxxxxxxxx, rjw@xxxxxxx, linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx, linux-trace-users@xxxxxxxxxxxxxxx, Jean Pihet <jean.pihet@xxxxxxxxxxxxxx>, Frederic Weisbecker <fweisbec@xxxxxxxxx>, Tejun Heo <tj@xxxxxxxxxx>, Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>
- In-reply-to: <1288115894.3673.12.camel@laptop>
- References: <1287488171-25303-3-git-send-email-trenn@xxxxxxx> <1288049630-10947-1-git-send-email-trenn@xxxxxxx> <20101026071020.GC13036@xxxxxxx> <AANLkTikWCLTgAGJJ_eH0e016kPfB2K8LtR9g25wbPJXF@xxxxxxxxxxxxxx> <4CC6FC03.708@xxxxxxxxxxxxxxx> <AANLkTinrmhBkjnXE+xQGgrsv_OR_ckz=dyH4EoDB59X_@xxxxxxxxxxxxxx> <1288115894.3673.12.camel@laptop>
On Tue, Oct 26, 2010 at 12:58 PM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> On Tue, 2010-10-26 at 11:56 -0500, Pierre Tardy wrote:
>>
>> + trace_runtime_pm_usage(dev, atomic_read(&dev->power.usage_count)+1);
>> atomic_inc(&dev->power.usage_count);
>
> That's terribly racy..
>
I know. I'm not proud of this.. As I said, this is preliminary patch.
We dont really need to have this prev_usage. This is just for debug.
It mayprobably endup with something like:
atomic_inc(&dev->power.usage_count);
+ trace_power_device_usage(dev);
--
Pierre
--
To unsubscribe from this list: send the line "unsubscribe linux-trace-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]