On Mon, 29 Jan 2024 at 08:00, Mathieu Desnoyers
<mathieu.desnoyers@xxxxxxxxxxxx> wrote:
>
> This breaks "cp -aH" and "cp -aL".
Do we care? Do we have a user that cares? Has anybody ever hit it?
Why would you ever do anything like that to tracefs filesystem?
In other words: my point is that tracefs just isn't a regular
filesystem. Never was, never will be.
And people should be *aware* of that. We should not say "hey, if it
doesn't work like a normal filesystem, it's a bug".
Try "cp -aL" on /proc, and guess what? It won't work all that well
either. For entirely *different* reasons. You'll get some variation of
"Input/output error"s, and insanely big files and quite possibly
you'll end up with recursive copying as you try to copy the file that
is /proc/self/fd/<output>.
It's just a nonsensical operation to do, and if somebody says "I can't
copy /proc on my system" it's a PEBKAC, not a kernel problem.
The "no regressions" rule is not about made-up "if I do this, behavior changes".
The "no regressions" rule is about *users*.
If you have an actual user that has been doing insane things, and we
change something, and now the insane thing no longer works, at that
point it's a regression, and we'll sigh, and go "Users are insane" and
have to fix it.
But if you have some random test that now behaves differently, it's
not a regression. It's a *warning* sign, sure: tests are useful.
So tests can show when something user-visible changed, and as such
they are a "there be monsters here" sign that maybe some user
experience will hit it too.
So I agree that "just use the same inode number" changes behavior. I
agree that it can be a bit of a danger. But these "look, I can see a
difference" isn't an argument.
And honestly, I have now spent *days* looking at tracefs, and I'm
finding core fundamental bugs that would cause actual oopses and/or
wild pointer accesses.
All of which makes me go "this code needs to be simpler and *cleaner*
and stop making problems".
In other words: tracefs is such a complete mess that I do not care one
*whit* about "cp -aL". I care about "this is actual kernel
instability".
Linus
|