Re: [PATCH 31/48] perf dwarf-aux: Add die_get_cfa()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH 31/48] perf dwarf-aux: Add die_get_cfa()
- From: Namhyung Kim <namhyung@xxxxxxxxxx>
- Date: Tue, 7 Nov 2023 21:28:19 -0800
- Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>, Jiri Olsa <jolsa@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Ian Rogers <irogers@xxxxxxxxxx>, Adrian Hunter <adrian.hunter@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, linux-perf-users@xxxxxxxxxxxxxxx, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Stephane Eranian <eranian@xxxxxxxxxx>, linux-toolchains@xxxxxxxxxxxxxxx, linux-trace-devel@xxxxxxxxxxxxxxx
- In-reply-to: <20231107095011.7538657bbe34f0d7171add09@kernel.org>
- References: <20231012035111.676789-1-namhyung@kernel.org> <20231012035111.676789-32-namhyung@kernel.org> <20231107095011.7538657bbe34f0d7171add09@kernel.org>
On Mon, Nov 6, 2023 at 4:50 PM Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
>
> On Wed, 11 Oct 2023 20:50:54 -0700
> Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
>
> > The die_get_cfa() is to get frame base register and offset at the given
> > instruction address (pc). This info will be used to locate stack
> > variables which have location expression using DW_OP_fbreg.
> >
>
> In the util/probe-finder.c, I added the elfutils version checker
>
> #if _ELFUTILS_PREREQ(0, 142)
>
> for CFI related code, in commit 7752f1b096e1 ("perf probe: Don't
> compile CFI related code if elfutils is old"). Maybe we'd better to have
> a config of HAVE_DWARF_CFI_SUPPORT for this.
Sounds like a good idea. Will add.
Thanks,
Namhyung
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]