Re: [RFC 00/48] perf tools: Introduce data type profiling (v1)
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [RFC 00/48] perf tools: Introduce data type profiling (v1)
- From: Namhyung Kim <namhyung@xxxxxxxxxx>
- Date: Thu, 12 Oct 2023 13:45:04 -0700
- Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>, Jiri Olsa <jolsa@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Ian Rogers <irogers@xxxxxxxxxx>, Adrian Hunter <adrian.hunter@xxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, linux-perf-users@xxxxxxxxxxxxxxx, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Stephane Eranian <eranian@xxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, linux-toolchains@xxxxxxxxxxxxxxx, linux-trace-devel@xxxxxxxxxxxxxxx, Ben Woodard <woodard@xxxxxxxxxx>, Joe Mario <jmario@xxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, David Blaikie <blaikie@xxxxxxxxxx>, Xu Liu <xliuprof@xxxxxxxxxx>, Kan Liang <kan.liang@xxxxxxxxxxxxxxx>, Ravi Bangoria <ravi.bangoria@xxxxxxx>
- In-reply-to: <ZSg73+7Ar/U2OWMO@gmail.com>
- References: <20231012035111.676789-1-namhyung@kernel.org> <ZSeMGPPfxkMvdaP3@gmail.com> <CAM9d7chzw4UeHHeXaMfPTiRdLbv7PbpK=xkgxMDojAxAc8y7Jg@mail.gmail.com> <ZSg73+7Ar/U2OWMO@gmail.com>
On Thu, Oct 12, 2023 at 11:33 AM Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
>
> * Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
>
> > > Could we perhaps add an IP filter to perf events to get this built-in?
> > > Perhaps attr->exclude_user would achieve something similar?
> >
> > Unfortunately IBS doesn't support privilege filters IIUC. Maybe
> > we could add a general filtering logic in the NMI handler but I'm
> > afraid it can complicate the code and maybe slow it down a bit.
> > Probably it's ok to have only a simple privilege filter by IP range.
>
> It will still be so much faster than moving it through the BPF machinery,
> and bonus points if we merge this into the existing privilege-domain
> filtering ABI, so no magic 0x800000000000 constants are needed.
>
> 'Overhead' to other usecases shouldn't be much more than a single branch
> somewhere.
Ok, maybe overhead is not a concern. But users need to pass the
filter expression to the kernel.
Thanks,
Namhyung
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]