Re: [PATCH] libtraceeval histogram: Add type to traceeval_data and make it a structure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 16 Aug 2023 11:41:45 -0400
Stevie Alvarez <stevie.6strings@xxxxxxxxx> wrote:

> >  void set_process_data(struct task_data *tdata, const char *comm, void *data)
> >  {
> > -	union traceeval_data keys[] = {
> > +	struct traceeval_data keys[] = {
> >  		{
> >  			.cstring = comm,
> >  		},  
> 
> Is there a reason you stop using the macros to define your
> traceeval_data array elements? Or a better question: Are these struct
> traceeval_data instances exempt to needing a type field? And if so, why?

No reason, I just missed this. I've updated it in my code and have a v2
ready to post. I just tested by compiling it. When I actually ran the code
(after posting the patches), it didn't give the same output, and found that
this was why :-p

-- Steve



[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux