Re: [PATCH v5 04/25] trace-cmd library: Add internal helper function for writing headers before file sections

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 6 Dec 2021 05:25:56 +0200
Tzvetomir Stoyanov <tz.stoyanov@xxxxxxxxx> wrote:

> The only reason to have a string is for "trace-cmd dump" - to be able
> to dump some description for unknown sections, we discussed that in
> the past. But now when I'm looking at that again - there is no sense
> to have it only for that reason, the ID is enough. I can remove the
> string from the header.

I think we also discussed it for when a new section was added that wasn't
known to the current trace-cmd, that it could give a more useful message.
i.e. "This version of trace-cmd does not handle 'New feature here', please
upgrade your trace-cmd". 

That way, the user would at least know why that new feature is not being
processed.

-- Steve



[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux