On Thu, 11 Nov 2021 17:09:00 +0200 "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@xxxxxxxxx> wrote: > Introduce headers before each file section, in trace file version 7. The > section header has the following format: > <2 bytes>, header ID > <string>, null terminated ASCII string, description of the header We may have discussed this before, but I don't remember. Why did we make the second item a string? I would think we would want all the fixed size portions of the header to be first, and the variable size portion to be last? <2 bytes> header ID <2 bytes> section flags <4 bytes> size of section. Although, is 4 bytes big enough? Perhaps it should be 8 bytes? What happens if a section is bigger than 4 gigs? And then have the string description at the end. Thoughts? -- Steve > <2 bytes>, section flags: > 1: the section is compressed > <4 bytes>, size of the section > > Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@xxxxxxxxx> > --- > include/trace-cmd/trace-cmd.h | 5 ++ > .../include/private/trace-cmd-private.h | 1 + > lib/trace-cmd/include/trace-cmd-local.h | 5 ++ > lib/trace-cmd/trace-output.c | 68 +++++++++++++++++++ > 4 files changed, 79 insertions(+) >
|