On Fri, 26 Nov 2021 21:20:26 +0900 Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote: > > We need to be careful about modifying content in event-parse.h. Because > > this is exposed outside he library. > > Oh, I thought this is an internal header, because it is under src/ directory. > However, indeed "TEP_FIELD_IS_*" referred from perf-tools, so this might be > need to be exposed. Yeah, we need to fix this. The issue was that this is loaded with legacy code. The code was created in trace-cmd, ported to the kernel into tools/lib/traceevent, then pulled out into it's own directory. The poor library had so many foster parents, that it wasn't ready to go out on its own. I'll fix some of this before posting a new version. -- Steve
|